Fix RESTRICTED_TOKENS typo: " javax" (leading space) fails to prevent javax binding#12709
Fix RESTRICTED_TOKENS typo: " javax" (leading space) fails to prevent javax binding#12709robinkarlberg wants to merge 1 commit intoapache:mainfrom
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
|
|
tnx @robinkarlberg , If you think this makes sense, would you mind basing your change on the 4.20 branch, we will merge forward to any following branches. If not, we’ll just merge here and it will go in 23 and up. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12709 +/- ##
=========================================
Coverage 17.92% 17.92%
- Complexity 16154 16157 +3
=========================================
Files 5939 5939
Lines 533181 533181
Branches 65237 65237
=========================================
+ Hits 95585 95595 +10
+ Misses 426856 426846 -10
Partials 10740 10740
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
Description
RESTRICTED_TOKENSis used to blacklist tokens for the JavaScript engine, used for rules etc. However, I saw that one of the entries" javax"has an accidental space in it, it should most likely be"javax".As far as I understand, the typo does not lead to any security impact as the
--no-javaflag disablesjavaxaccess, so that's why I'm creating an issue here on GitHub, and not a vulnerability disclosure. Consider this more of a little cleanup of the code.Types of changes
How Has This Been Tested?
Test still pass.